Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-calendar, b-form-datepicker): add optional decade navigation buttons (addresses #4976) #5112

Merged
merged 32 commits into from Apr 7, 2020

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Apr 6, 2020

Describe the PR

Adds new prop show-decade-nav to enable optional +/- decade navigation

Addresses parts of #4976

To Do:

  • b-calendar unit tests
  • update b-form-datepicker
  • b-calendar docs
  • b-form-datepicker docs

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse added Status: WIP Type: Feature PR: Minor labels Apr 6, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 6, 2020

Codecov Report

Merging #5112 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5112   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         277      277           
  Lines        6522     6522           
  Branches     1612     1612           
=======================================
  Hits         6519     6519           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca26b84...ca26b84. Read the comment docs.

@tmorehouse tmorehouse changed the title feat(b-calendar, b-form-datepicker): add optional decade navigation buttons feat(b-calendar, b-form-datepicker): add optional decade navigation buttons (addresses #4976) Apr 6, 2020
@tmorehouse tmorehouse added this to In progress in 2.11.0 via automation Apr 6, 2020
@tmorehouse tmorehouse marked this pull request as ready for review Apr 7, 2020
@tmorehouse tmorehouse requested a review from jacobmllr95 Apr 7, 2020
@tmorehouse tmorehouse mentioned this pull request Apr 7, 2020
@tmorehouse
Copy link
Member Author

@tmorehouse tmorehouse commented Apr 7, 2020

@jackmu95 Do you think the decade buttons should be opt-in (as current in this PR, set prop to show), or opt-out (shown by default, set prop to hide)?

Current opt-in demo: https://deploy-preview-5112--bootstrap-vue.netlify.com/docs/components/calendar#internationalization

We could make the decade buttons automatic by default (depending on the range for min/max). basically a tri-state prop... null for auto, true for always show, and false for never show?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Minor Type: Feature
Projects
No open projects
2.11.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants