Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Using default browser to Open Note in Web App. #22

Closed
metalbrick opened this issue May 7, 2014 · 4 comments
Closed

Not Using default browser to Open Note in Web App. #22

metalbrick opened this issue May 7, 2014 · 4 comments

Comments

@metalbrick
Copy link

Maybe you would like change the open_url method in line:675 in sublime_evernote.py

- self.view.window().run_command("open_url", {"url": url % self.view.settings().get("$evernote_guid")})
+ webbrowser.open_new_tab(url % self.view.settings().get("$evernote_guid"))
@bordaigorl
Copy link
Owner

@metalbrick What do you mean exactly by default browser? Which system are you on?
It works just fine in my system. I would have guessed that open_url is defined using webbrowser anyway so I could not see the big difference...

@metalbrick
Copy link
Author

I use chrome as default browser under my kubuntu, but the method used
in current version will open the note by firefox for me.

On 5/8/14, bordaigorl notifications@github.com wrote:

@metalbrick What do you mean exactly by default browser? Which system are
you on?
It works just fine in my system. I would have guessed that open_url is
defined using webbrowser anyway so I could not see the big difference...


Reply to this email directly or view it on GitHub:
#22 (comment)

@bordaigorl
Copy link
Owner

Ok, it's a very inconsequential change so, since it improves the behaviour of the plugin I'll incorporate it in next release. Thanks for the feedback!

@metalbrick
Copy link
Author

My pleasure, you've done a fantastic job, I've been looking for the
exactly application can combine markdown and evernote like years, not
mentioned that it worked cross-platform. I really appreciate your
work.

On 5/8/14, bordaigorl notifications@github.com wrote:

Ok, it's a very inconsequential change so, since it improves the behaviour
of the plugin I'll incorporate it in next release. Thanks for the feedback!


Reply to this email directly or view it on GitHub:
#22 (comment)

@bordaigorl bordaigorl added this to the Version 2.5.2 milestone Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Milestone
Version 2.5.2
Development

No branches or pull requests

2 participants