Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab with new unsaved Evernote note should not be closed without dialog query #95

Open
rdhyee opened this issue May 27, 2015 · 5 comments

Comments

@rdhyee
Copy link

rdhyee commented May 27, 2015

Today I had a new note created with the sublime-evernote plugin that I didn't get around to saving to Evernote. I accidentally hit the Cmd-W button on my Mac to close the tab, losing about an hour of work. (more painful in retrospect than at this moment!)

What surprised me was that I didn't get any dialog box to prompt me about whether I really did want to close the tab. Is there some setting I can use to prevent this accidental closing of a tab from happening again?

@rdhyee
Copy link
Author

rdhyee commented May 27, 2015

It seems that the only way to keep a tab from being accidentally closed is I've used the Update Evernote Note function on the note. Even if I have just used the Send to Evernote as new noteand made a change to the note, I can close the tab without having to choose between Close and discard changes and Save to Evernote and close.

@bordaigorl
Copy link
Owner

Can you check you are running the latest version (2.6.0) and the warn_on_close setting is set to true?

@rdhyee
Copy link
Author

rdhyee commented May 27, 2015

Yes, I'm running the latest version (2.6.0), but I don't have warn_on_close explicitly set. My understanding is that warn_on_close defaults to true. As I noted previously. I do get a warning once I've used Update Evernote Note on a note.

@bordaigorl
Copy link
Owner

Ah yes sorry that was a bug which is already corrected in the devel branch but has not been released as a version yet.
I might actually publish 2.6.1 with that change alone...to solve your problem until I do that you can clone the repo from the devel branch and it should work as expected. I am sorry you lost your note...

@rdhyee
Copy link
Author

rdhyee commented May 27, 2015

Thanks, @bordaigorl for looking into my problem. I'm glad the problem is fixed in the devel branch. Yes, it was a pain to loose my note...but I can hardly complain too much given how much I benefit from your fantastic ST-Evernote integration. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants