Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Translation Thread #159

Open
m3nu opened this issue Jan 22, 2019 · 27 comments
Assignees
Labels

Comments

@m3nu
Copy link
Contributor

@m3nu m3nu commented Jan 22, 2019

This thread is to coordinate the actual translation work. So far working on translations:

Translations are organized on Transifex (TF) and then pulled into the source code, when 90+% complete. The site to sign up is:

https://www.transifex.com/borgbase/vorta/

I'll do one more check of all English strings today, then update them on TF and then confirm all TF translators.

Last, we should mention translators somewhere in the credits or the README. There will also be new strings added over time, as we're still adding features. So it's an ongoing commitment.

@m3nu m3nu self-assigned this Jan 22, 2019
@m3nu m3nu added the type:task label Jan 22, 2019
@dbrassard

This comment has been minimized.

Copy link

@dbrassard dbrassard commented Jan 22, 2019

You can also use my GitHub handle

I am /u/dbrass from Reddit

@ThomasWaldmann

This comment has been minimized.

Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann commented Jan 22, 2019

There could be also a more general "CONTRIBUTORS" file, where everybody who contributed something (to code, to docs, to i18n, ...) can get added.

@ThomasWaldmann

This comment has been minimized.

Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann commented Jan 22, 2019

BTW, i noticed that transifex or the qt tools seem to just kill strings that do not completely match any more (or did I miss something?). So having the *.ts files in git is useful to c&p longer translated phrases and then just edit them as needed.

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 22, 2019

Sometimes these services have a "translation memory". Even if the string was removed, it may suggest the removed translation for a similar string in the future. But yes, good to look it up on Github sometimes.

(Added GH handle for @dbrassard )

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 22, 2019

BTW, i noticed that transifex or the qt tools seem to just kill strings that do not completely match any more (or did I miss something?). So having the *.ts files in git is useful to c&p longer translated phrases and then just edit them as needed.

Those strings stay in "translation memory" and you can find them via Suggestions. I just played with replacing three dots with an ellipsis, but reverted back due to unicode-issues and your translations were still there.

screen shot 2019-01-22 at 12 04 54

@ThomasWaldmann

This comment has been minimized.

Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann commented Jan 22, 2019

You had an exact match in that case.

What I meant are fuzzy matches - did these work for you also?

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 22, 2019

Yes. Then it just gives you a e.g. 90% match and ranks it by match. So for each new string you get similar past matches.

I refactored many strings today and it was very helpful to keep the German translation updated.

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 23, 2019

Added everyone who asked to join to the translation group. Short intro here. But probably better to keep most discussion on Github.

Let me know how it goes, @dbrassard @brokenpip3. No tools are required to enter translations, but testing them needs Qt and the Transifex CLI, as described in CONTRIBUTING.md > Translations.

@dbrassard

This comment has been minimized.

Copy link

@dbrassard dbrassard commented Jan 23, 2019

For strings with punctuation marks, should the translated text keep those?
eg. "Repository Path:"

Also, the section "Data Flow to/from Transifex" is unclear to me.

Finally, is there resources highlighting the proper workflow for Transifex? I can go on the website and translate strings but I need to test them in the final application. I installed the qt5 dev tools but I will still need some pointers (consider that I'm not a software developer).

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 23, 2019

For strings with punctuation marks, should the translated text keep those?
eg. "Repository Path:"

Yes. Please keep all the punctuation marks including ..., : and .

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Jan 23, 2019

I need to test them in the final application. I installed the qt5 dev tools but I will still need some pointers (consider that I'm not a software developer).

There are a few ways to do this. Easiest is maybe:

  1. download .ts file from Transifex
  2. put it in src/vorta/i18n/ts
  3. run make translations-to-qm
  4. run vorta command

This assumes you already have Vorta installled as dev setup (editable installation from git). If not and you need further steps, let me know.

@brokenpip3

This comment has been minimized.

Copy link

@brokenpip3 brokenpip3 commented Jan 23, 2019

Italian translation started.. give me a few days

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 1, 2019

How are translations coming along? I see about half completed on Transifex. Good progress!

I was planning the next release when languages are done. Would be a few bug fixes and languages mostly.

m3nu added a commit to ThomasWaldmann/vorta that referenced this issue Feb 1, 2019
@m3nu m3nu added this to the v0.6.z Branch milestone Feb 1, 2019
@brokenpip3

This comment has been minimized.

Copy link

@brokenpip3 brokenpip3 commented Feb 3, 2019

How are translations coming along? I see about half completed on Transifex. Good progress!

I'm near to finish (85%) it but i must review some choice.
I work on this a little time most days. I hope to finish the translations very soon.

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 12, 2019

Just saw that Italian is now complete. Will we release French at the same time?

@dbrassard

This comment has been minimized.

Copy link

@dbrassard dbrassard commented Feb 12, 2019

It is getting along. I'll have time to do some more translation today. Some strings just give me a bit of trouble :
"nyx2.local-2018-11-16T09:49:58 from November 16, 2018".

I will also need to test out the translation as I just used the Transifex interface until now.

Do we need to validate/revise each translation in the Transifex interface?

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 12, 2019

"nyx2.local-2018-11-16T09:49:58 from November 16, 2018".

Looks like a placeholder. Either copy it or ignore and I'll remove it later.

The way you did it is fine. Just do "Save Changes". We don't use the review feature for now.

@dbrassard

This comment has been minimized.

Copy link

@dbrassard dbrassard commented Feb 12, 2019

I finished the french translation today but I will need to test it in the application to spot mistakes.

This assumes you already have Vorta installled as dev setup (editable installation from git). If not and you need further steps, let me know.

I know how to pull a repository from git and push modifications but that's about it. What are the commands to build and install Vorta in dev mode? Do I need to rebuild the application completely when I switch the language file? It seems as I can modify the language of an already compiled program with the \. make translations-to-qmcomand.

P.S. I'm running Ubuntu 16.04

@ThomasWaldmann

This comment has been minimized.

Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann commented Feb 12, 2019

m3nu added a commit that referenced this issue Feb 13, 2019
@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 13, 2019

This is amazing. I can't judge the actual translation, but it's fascinating that it works as expected. Your translations are already in the master-branch, which should make testing easier. I can also make some screenshots for you if that's quicker. In theory the steps are like this:

  1. Checkout latest master branch or clone repo. $ git clone https://github.com/borgbase/vorta
  2. Go to vorta root folder and run $ make translations-to-qm to compile translations.
  3. Install editable version of Vorta: $ pip install -e .
  4. Run Vorta with $ vorta. If you want to use a different language, use $ LANG=it vorta
@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 13, 2019

Some screenshots of the first tab and system tray menu:

screen shot 2019-02-13 at 15 50 34

screen shot 2019-02-13 at 15 50 04

@brokenpip3

This comment has been minimized.

Copy link

@brokenpip3 brokenpip3 commented Feb 13, 2019

Yesterday night i tried my translation, i found one error and 2-3 string to replace for better "standard word pick".
Today i replace them asap

@brokenpip3

This comment has been minimized.

Copy link

@brokenpip3 brokenpip3 commented Feb 14, 2019

Ok fixed (i hope). (y)

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Feb 20, 2019

The new translations are now live as version 0.6.10. Please make sure it all shows correctly.

I'll pull new translations from Transifex before every release from now on, in case something needs changing.

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Mar 6, 2019

I'll soon add the latest translations for the next release. There are a few new strings that cover the new "Pass extra arguments to Borg" and "Improve compression options" functionality.

I already added translations for German. Maybe you guys can update FR and IT. @brokenpip3 @dbrassard 🙌🙌

Untranslated strings: https://www.transifex.com/borgbase/vorta/translate/#fr/vorta/165834924?q=translated%3Ano

@m3nu m3nu removed this from the v0.6.z Branch milestone Mar 6, 2019
@brokenpip3

This comment has been minimized.

Copy link

@brokenpip3 brokenpip3 commented Mar 19, 2019

I'll soon add the latest translations for the next release. There are a few new strings that cover the new "Pass extra arguments to Borg" and "Improve compression options" functionality.

I already added translations for German. Maybe you guys can update FR and IT. @brokenpip3 @dbrassard raised_handsraised_hands

Untranslated strings: https://www.transifex.com/borgbase/vorta/translate/#fr/vorta/165834924?q=translated%3Ano

I'm very sorry, i translated the new string the day after your post this message but forgot to reply here.

@m3nu

This comment has been minimized.

Copy link
Contributor Author

@m3nu m3nu commented Mar 20, 2019

No problem. I pulled all available translations for the release. So if they were on Transifex they should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.