Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"+" button ("add profile") misses a mouseover text #183

Closed
ThomasWaldmann opened this issue Feb 8, 2019 · 1 comment
Closed

"+" button ("add profile") misses a mouseover text #183

ThomasWaldmann opened this issue Feb 8, 2019 · 1 comment
Labels
good first issue Simple change to start learning code base

Comments

@ThomasWaldmann
Copy link
Collaborator

The other 2 icons ("rename" and "delete" profile) have a mouse over, but "add" does not.
@ThomasWaldmann ThomasWaldmann added the good first issue Simple change to start learning code base label Feb 8, 2019
Plastix added a commit to Plastix/vorta that referenced this issue Feb 10, 2019
@Plastix
Add tooltip to "add profile" button (borgbase#183)
9bb8673 
Background:
Currently the "rename" and "delete" profile buttons have mouse-over
tooltips. This commit adds a tooltip to the "add profile" button

Modifications:
* Change the string property on `profileAddButton` from `text` to `toolTip`.

Steps to test:
* Launch Vorta and mouse-over the "+" button.
Plastix added a commit to Plastix/vorta that referenced this issue Feb 10, 2019
@Plastix
Add tooltip to "add profile" button (borgbase#183)
a5fc22a 
Background:
Currently the "rename" and "delete" profile buttons have mouse-over
tooltips. This commit adds a tooltip to the "add profile" button

Modifications:
* Change the string property on `profileAddButton` from `text` to `toolTip`.

Steps to test:
* Launch Vorta and mouse-over the "+" button.

Fixes borgbase#183
@Plastix Plastix mentioned this issue Feb 10, 2019
Merged
@Plastix
Copy link
Contributor

Plastix commented Feb 10, 2019 •
edited
Loading

This was an oversight when I implemented the add profile feature. Small PR out to address this. Thanks!

@m3nu m3nu closed this as completed in #189 Feb 11, 2019
m3nu pushed a commit that referenced this issue Feb 11, 2019
@Plastix @m3nu
Add tooltip to "add profile" button. Fixes #183 (#189)
85996c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Simple change to start learning code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomasWaldmann @Plastix