Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor names #55

Closed
ThomasWaldmann opened this issue Nov 24, 2018 · 2 comments
Closed

refactor names #55

ThomasWaldmann opened this issue Nov 24, 2018 · 2 comments
Assignees
@m3nu
Milestone
v0.6.0 Release

Comments

@ThomasWaldmann
Copy link
Collaborator

ThomasWaldmann commented Nov 24, 2018 •
edited

as seen in #54, some names are too specific - it's not always a directory or folder, can be any fs item.

e.g.:

  • sourceDirectoriesWidget
  • sourceDirModel
  • choose_folder_dialog
  • dir = ...
  • ... (?)
@m3nu m3nu added this to the v0.6.0 Release milestone Nov 27, 2018
@m3nu
Copy link
Contributor

m3nu commented Dec 3, 2018

All directories are files, but not all files are directories --source

So calling them all files would be correct?

@m3nu m3nu self-assigned this Dec 3, 2018
@m3nu
Copy link
Contributor

m3nu commented Dec 5, 2018

Refactored most objects around the files and folders to be backed up. Including the ORM model. Will do the rest whenever I notice them.

@m3nu m3nu closed this as completed Dec 5, 2018
m3nu added a commit to m3nu/vorta that referenced this issue Dec 5, 2018
@m3nu
Use the term FILE if both FILE or FOLDER is meant. Fixes borgbase#55
2b2cd73
m3nu added a commit that referenced this issue Dec 5, 2018
@m3nu
v0.5.3 (#80)
3c519e4 
* Apply selection status to children in restore-dialog. Fixes #69

* Backup triggered from system tray wont use correct profile. Fixes #78

* Use the term FILE if both FILE or FOLDER is meant. Fixes #55

* Implement update check on/off setting for macOS

* Implement autostart setting for macOS. Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m3nu m3nu

Labels
None yet
Projects
None yet
Milestone
v0.6.0 Release
Development

No branches or pull requests
2 participants
@ThomasWaldmann @m3nu