Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Tab #56

Closed
adamluk opened this issue Nov 24, 2018 · 7 comments
Closed

Settings Tab #56

adamluk opened this issue Nov 24, 2018 · 7 comments
Labels
os:macos Affects only macOS type:enhancement Improvement of an existing function
Milestone
v0.6.0 Release

Comments

@adamluk
Copy link

adamluk commented Nov 24, 2018

I have Vorta selected to open automatically when I login through System Prefs > Users & Groups.

I wonder if it would be possible to have an option within Vorta to open at login?

Also - an option to open minimised to the menu bar so that the Vorta Settings window does not show automatically at launch is perhaps a good idea for any implementation of open at login?
@m3nu m3nu added priority:low Nice to have feature, minor improvement to functionality or usability type:enhancement Improvement of an existing function os:macos Affects only macOS labels Nov 26, 2018
@m3nu m3nu changed the title Open Vorta at login [Mac OS] Settings Tab Nov 28, 2018
@m3nu
Copy link
Contributor

m3nu commented Nov 28, 2018 •
edited
Loading

Could make sense to add another tab for global settings. What comes to mind:

  1. start at login as suggested here. How to implement for Linux?
  2. Notifications on/off
  3. Open settings screen on start on/off
  4. Check for updates. (currently always happens on startup)
  5. Check for full disk access
  6. Use light/dark tray icon (system tray icon #74 )

@m3nu m3nu removed os:macos Affects only macOS priority:low Nice to have feature, minor improvement to functionality or usability labels Nov 28, 2018
@ThomasWaldmann
Copy link
Collaborator

for linux, many of these seem problematic:

  1. not sure if there even is one method that works for every WM/DE.
  2. same for that
  3. maybe this is not needed if we assume that vorta should usually just start and do its job in the background. the few times it needs to open settings could be just done manually (invoking it from the system tray). for devs there could be vorta --settings.
  4. this would be also a very unusual thing on linux, updates there are automatically installed from the distribution usually.

@m3nu
Copy link
Contributor

m3nu commented Nov 28, 2018

I see. So this will mostly be macOS-specific. Let me know if any other settings could make sense for Linux.

@m3nu m3nu added the os:macos Affects only macOS label Nov 29, 2018
@m3nu
Copy link
Contributor

m3nu commented Nov 30, 2018

maybe this is not needed if we assume that vorta should usually just start and do its job in the background. the few times it needs to open settings could be just done manually (invoking it from the system tray). for devs there could be vorta --settings.

Agree. It should be clear enough from the GIF that there is a menu icon. So the main window doesn't open on startup any more since #63 (v0.5.1)

I'll still add those macOS goodies, but for Linux the focus will be on stability and bug from now on.

@m3nu m3nu added this to the v0.6.0 Release milestone Dec 2, 2018
m3nu added a commit to m3nu/vorta that referenced this issue Dec 2, 2018
@m3nu
Add settings tab. Add light system tray icon option. Fixes borgbase#56 …
73f90ac 
…and borgbase#74
@m3nu
Copy link
Contributor

m3nu commented Dec 2, 2018

Added. For now there are 1 (Linux)/4 (macOS) options. But I suspect this to increase over time.

@m3nu m3nu closed this as completed Dec 2, 2018
m3nu added a commit that referenced this issue Dec 4, 2018
@m3nu
v0.5.2 Bugfixes and new Misc Settings Tab (#71)
30c6549 
* Fix uneven vspace. Fixes #67

* Add Python 3.7 to Travis. Use tox to test multiple Python versions. Fixes #72

* Add command line option to avoid forking and open main window while debugging. Fixes #73

* Use slug of profile name as archive prefix. Fixes #46

* Add settings tab. Add light system tray icon option. Fixes #56 and #74

* Incorporate review by @ThomasWaldmann
m3nu added a commit to m3nu/vorta that referenced this issue Dec 5, 2018
@m3nu
Implement autostart setting for macOS. Fixes borgbase#56
a9d7e28
@m3nu
Copy link
Contributor

m3nu commented Dec 5, 2018

Setting as login item is now implemented. @adamluk

screenshot 2018-12-05 at 16 46 43

m3nu added a commit that referenced this issue Dec 5, 2018
@m3nu
v0.5.3 (#80)
3c519e4 
* Apply selection status to children in restore-dialog. Fixes #69

* Backup triggered from system tray wont use correct profile. Fixes #78

* Use the term FILE if both FILE or FOLDER is meant. Fixes #55

* Implement update check on/off setting for macOS

* Implement autostart setting for macOS. Fixes #56
@m3nu
Copy link
Contributor

m3nu commented Dec 5, 2018

Correction: There is a conflict with the Keychain package. Can't add the login item stuff just yet. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:macos Affects only macOS type:enhancement Improvement of an existing function
Projects
None yet
Milestone
v0.6.0 Release
Development

No branches or pull requests
3 participants
@ThomasWaldmann @m3nu @adamluk