Diff view now shows folder sizes as sum of sizes of contained items #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! We had an open issue for this actually. |
|
Fixes #1140 |
m3nu
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
This is a useful addition and I didn't notice any performance problems. Might start using the diff feature actually. 😄
Any objections or comments, @Hofer-Julian ? Since this feature is your baby.
|
We also have #1138 to add sorting by size for diffs. It adds more code, but isolated in one class. And the contributor didn't adjust the tests yet. |
Hofer-Julian
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that I wanted a diff view which would allow me to investigate unexpectedly large backups. Since the size column was unused on the current diff view, and it seemed natural to me to have it be the sum of the size of the contained items, I made that change.
String compare is used when filtering because large diffs were taking too long with os.path.commonpath, which is more general than what we need here.