-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update label displaying next backup time. #1180
Update label displaying next backup time. #1180
Conversation
I was able to track the error down: When This is clearly an issue with the testing setup or maybe with |
Redoing all the tests sounds like a big task just to preview the next scheduler run more often. I keep the app around, but reset the database and windows during tests. Destroying the whole app would take much longer and caused segfaults from Qt, as it expects only one Qt app per process. 😬 |
625b42b
to
1ed23be
Compare
I implemented a work-around for the failing test. |
That's a clever implementation and good workaround for the test. Did something like this myself in a few places. Good job! Let me run this locally for a while and then merge. Thanks! |
1ed23be
to
3601ede
Compare
Do you know that you don't have to merge the master into the feature branch if you merge it into master afterwards? In case you want to check the tests you can also rebase the branch from within the github ui or using |
…imer. Fixes borgbase#1116. * src/vorta/scheduler.py (VortaScheduler): Add `schedule_changed` signal. * src/vorta/scheduler.py (VortaScheduler.set_timer_for_profile): Emit `schedule_changed` signal. * src/vorta/views/schedule_tab.py (ScheduleTab): Connect `draw_next_scheduled_backup` to `schedule_changed` signal.
* tests/test_schedule.py : Work around old scheduletabs still being connected to the scheduler's signal by reconnecting the scheduletab.
c809de7
to
cc9348e
Compare
Works as promised. Very elegant solution. Thanks for taking care! 💃 |
Always update the label in the schedule tab that displays the next time to start a backup when the scheduler updates its timer.
Fixes #1116.
src/vorta/scheduler.py (VortaScheduler): Add
schedule_changed
signal.src/vorta/scheduler.py (VortaScheduler.set_timer_for_profile): Emit
schedule_changed
signal.src/vorta/views/schedule_tab.py (ScheduleTab): Connect
draw_next_scheduled_backup
toschedule_changed
signal.