Delete existing sources on profile overwrite #1942 #1958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
THank you very much. Looks good! Is it possible to add a test case checking for this bug? |
|
Sure! |
|
Hey @TheLazron are you still working on this? |
Our `DiffResultDialog` and `ExtractDialog` show a context menu for items of the list/tree view. The collapse action in this menu only makes sense for the tree mode of the view. This commit therefore enables the option only for this view mode. * src/vorta/views/extract_dialog.py * src/vorta/views/diff_result.py * tests/unit/test_diff.py : Add tests for the new behaviour. * tests/unit/test_extract.py
The profile list in the main window is already sorted by name (alphabetically, case-sensitive). However the profile list in the *Backup Now* action found in the tray menu wasn't. This commit constructs the sql query to return the profiles in order. * src/vorta/tray_menu.py
shivansh02
force-pushed
the
duplicate-sources-on-overwrite-#1942
branch
from
75f6e54
to
ca15511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If overwrite is checked on profile import, existing sources for that profile are deleted before adding the new ones from the
jsonfile for that profileRelated Issue
Fixes #1942
Motivation and Context
Checking overwrite when importing an existing profile, resulted in duplicate source folders. The changes make sure to delete the existing set of sources before adding new ones for that profile
How Has This Been Tested?
This has been tested by exporting a profile with existing sources and importing it again. After checking
overwriting existing profile, only the new set of sources were being usedScreenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.