Skip to content

Commit

Permalink
Reduce Shonan pMin to 3
Browse files Browse the repository at this point in the history
  • Loading branch information
ayushbaid committed May 14, 2024
1 parent 29f23ba commit 92ea13d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions gtsfm/averaging/rotation/shonan.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
Authors: Jing Wu, Ayush Baid, John Lambert
"""

from typing import Dict, List, Optional, Set, Tuple

import gtsam
Expand Down Expand Up @@ -46,8 +47,9 @@ def __init__(self, two_view_rotation_sigma: float = _DEFAULT_TWO_VIEW_ROTATION_S
Args:
two_view_rotation_sigma: Covariance to use (lower values -> more strictly adhere to input measurements).
"""
super().__init__()
self._two_view_rotation_sigma = two_view_rotation_sigma
self._p_min = 5
self._p_min = 3
self._p_max = 64

def __get_shonan_params(self) -> ShonanAveragingParameters3:
Expand Down Expand Up @@ -143,10 +145,10 @@ def _nodes_with_edges(
"""Gets the nodes with edges which are to be modelled as between factors."""

unique_nodes_with_edges = set()
for (i1, i2) in i2Ri1_dict.keys():
for i1, i2 in i2Ri1_dict.keys():
unique_nodes_with_edges.add(i1)
unique_nodes_with_edges.add(i2)
for (i1, i2) in relative_pose_priors.keys():
for i1, i2 in relative_pose_priors.keys():
unique_nodes_with_edges.add(i1)
unique_nodes_with_edges.add(i2)

Expand Down

0 comments on commit 92ea13d

Please sign in to comment.