Use average coordinate of merged keypoints during NMS #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-retrieval-baseline
…re-retrieval-baseline
…re-retrieval-baseline
…re-retrieval-baseline
johnwlambert
changed the base branch from
master
to
add-pure-retrieval-baseline
Comment on lines
+59
to
+62
| # Modify global keypoint coordinate to be set to average value of merged detections, instead of | ||
| # using the first identified coordinate. | ||
| updated_uv = np.mean([per_image_kpt_coordinates[i][img_global_kpt_idx], uv], axis=0) | ||
| per_image_kpt_coordinates[i][img_global_kpt_idx] = updated_uv |
There was a problem hiding this comment.
Shouldn't you take the mean after you've determined which keypoints are to be merged?
| is_identical = np.any(diff_norms == 0) | ||
| if len(per_image_kpt_coordinates[i]) > 0 and is_identical: | ||
| is_duplicate = np.any(diff_norms <= self.nms_merge_radius) | ||
| if len(per_image_kpt_coordinates[i]) > 0 and is_duplicate: |
There was a problem hiding this comment.
have you tested with len(per_image_kpt_coordinates[i]) == 0? does the <= work with empty arrrays?
Also np.any should be false in that case, so you would not need that condition at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.