Added CReTA #775
Open
Added CReTA #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Could we remove this tsv file from the PR?
| Each row in the matrix contains (xi,yi,xj,yj) where xi,yi and xj,yj | ||
| are coordinates for images i,j respectively afer correcting for camera intrinsics. | ||
| R_avg: 3X3XN matrix of absolute rotations. [iRw in our notation] | ||
| maxImages: Maimum No. of images in the dataset (used for indexing) |
There was a problem hiding this comment.
nit: typo on
Maximum number of images in the dataset (used for indexing).
| from typing import Dict, List, Optional, Tuple | ||
|
|
||
| import numpy as np | ||
| from scipy.io import savemat, loadmat |
There was a problem hiding this comment.
let's import only the module, as import scipy.io, instead of importing the function.
| savemat(f"ta_input_{matches_hash}.mat", {"RT": RT, "edges": edges, "R_avg": R_avg, "matches": matches}) | ||
| if not os.path.isfile(f"ta_output_{matches_hash}.mat"): | ||
| raise FileExistsError("Could not find CReTA translation averaging solution.") | ||
|
|
There was a problem hiding this comment.
could we add a comment for L98 about what needs to be run in between L97 and L100?
There was a problem hiding this comment.
Could you remove this .asv file and all the other .asv files? (autosaved files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.