Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MST initialization with huber loss #802

Open
wants to merge 5 commits into
base: feature/shonan_mst_init
Choose a base branch
from
Open

Use MST initialization with huber loss #802

wants to merge 5 commits into from

Conversation

ayushbaid
Copy link
Contributor

No description provided.

@ayushbaid
Copy link
Contributor Author

This seems to do better

ba
ra

@akshay-krishnan
Copy link
Collaborator

@ayushbaid the diff is against "MST w/o Huber", not "no MST" right? Are we still seeing regressions when compared to "no MST"?

@ayushbaid
Copy link
Contributor Author

@ayushbaid the diff is against "MST w/o Huber", not "no MST" right? Are we still seeing regressions when compared to "no MST"?

The metrics are compared against master though

@akshay-krishnan
Copy link
Collaborator

@ayushbaid the diff is against "MST w/o Huber", not "no MST" right? Are we still seeing regressions when compared to "no MST"?

The metrics are compared against master though

Yes, I meant the diff in metrics.

@ayushbaid
Merge branch 'feature/shonan_mst_init' into feature/shonan_mst_huber
ff3b67a
@ayushbaid
Bump up shonan optimality threshold param
eaf4c02 
This commit passes in the optimality treshold explicitly from GTSFM: a value of `-1e-5` compared to `-1e-4` default value.
I tried using 0 and `1e-5` (value used in paper for large datasets) but even the unit tests are taking up a lot of time with higher thresholds.
@ayushbaid
Turn off weighing by inliers
03d754d
travisdriver
travisdriver requested changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@travisdriver travisdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you turn off inlier weighting?

@travisdriver
Copy link
Collaborator

Also, are you sure inlier weighting was turned on it master when you compared? I vaguely remember @akshay-krishnan accidently turning it off in master.

@ayushbaid
Copy link
Contributor Author

Why did you turn off inlier weighting?

It was just for experimentation and comparing different sets of values.

Inlier weighting is on right now on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisdriver travisdriver travisdriver requested changes

@akshay-krishnan akshay-krishnan Awaiting requested review from akshay-krishnan

@johnwlambert johnwlambert Awaiting requested review from johnwlambert

@dellaert dellaert Awaiting requested review from dellaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ayushbaid @akshay-krishnan @travisdriver