Add Noon Pacific (noonpacific.com) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iver56
force-pushed
the
noon-pacific
branch
2 times, most recently
from
f5973f8
to
f3c1140
Compare
|
I agree on that. |
|
Ideally noonpacific.com should implement #122. Can we try this approach first? |
|
@borismus I've notified one of the guys at noonpacific.com |
|
As noonpacific.com still don't support our generic API, we can merge this PR. @iver56, can your resolve the conflict with README, please? |
|
I resolved conflict by myself. Merged in #209 |
|
Sweet! Thanks for getting this in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that on noonpacific.com the simulated click only worked correctly with cancelable = true. [1] cancelable = true was not the default, so I had to create a way to override the default by passing an
optionsobject. The existing usage ofsimulateClick, where only one parameter (the element) is passed, should still work as before.[1] The control buttons on noonpacific.com are actually anchors (
atags withhrefset to an empty string) that reload the entire page by default, but the click handlers on noonpacific.com use preventDefault to prevent that, and create the wanted behavior. Only with cancelable = true can noonpacific.com correctly cancel the unwanted navigation, and perform the appropriate music control actions.http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-flow-cancelation