Default tag clojure added automatically without ability to change or have no tags at all
#51
Comments
|
Sounds good. cc @jmglov |
|
I just made a PR on this issue (actually my first-ever, so I hope everything is fine :)): #52 “Tagged:” will still appear in the HTML output, maybe it could be removed if there are no tags, but I wasn’t sure how to check for an empty collection in the template language ( |
|
@formsandlines I added a test runner on CI now. I noticed there were some flaky tests and I disabled those. Can you merge the main branch into your PR so your PR will run the tests automatically as well? Then I'll look at the rest of your PR. |
|
Updated the PR via the Github UI |
borkdude
pushed a commit
that referenced
this issue
Dec 28, 2022
* Moved default tag `clojure` to `:default-metadata` such that users can add their own default tags and fixed a bug when providing an empty vector if a user wants to add no tags at all. * Bumped babashka CLI to 0.6.41 * Changed failing test for api/migrate to compare sets of lines instead, as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the latest commit, while the
--tagsoption forquickblog newis not required anymore, the default tagclojureis still added automatically. I would prefer to be able to specify a different default tag or none at all, if desired.@borkdude suggested introducing a
:default-tagsoption, which I think is a good idea. I guess setting this to an empty vector could get rid of theTags: …field in .md files entirely or just leave it empty.The text was updated successfully, but these errors were encountered: