Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

The whole "alert box" thing needs redone #21

Closed
notriddle opened this issue Jan 9, 2017 · 0 comments · Fixed by #298
Closed

The whole "alert box" thing needs redone #21

notriddle opened this issue Jan 9, 2017 · 0 comments · Fixed by #298

Comments

@notriddle
Copy link
Member

notriddle commented Jan 9, 2017 •
edited
Loading

Right now, the HTML code to do alert boxes is duplicated throughout several templates. It differs for some of them, because some alert boxes are shown by JavaScript (the "this list is out of date" alerts on the project show.iex pages), and some of them are shown by Elixir (anything involving put_flash is done this way).

The code for the put_flash triggered ones should be separated into its own IEX file. It should also be wired up to a JavaScript button so that the user can close them. The JavaScript-triggered ones may be able to reuse the same one that flash uses, and it can definitely be wired up so the user can dismiss it.
@notriddle notriddle changed the title It should be possible to dismiss alert boxes The whole "alert box" thing needs redone Jan 9, 2017
@notriddle notriddle added the L-iex label Jan 9, 2017
@notriddle notriddle mentioned this issue Apr 6, 2017
Closed
notriddle added a commit to notriddle/bors-ng that referenced this issue Sep 20, 2017
@notriddle
Change the alert box layout
cfc5083 
Fixes bors-ng#19, have the notification unhide an element instead of adding it.

Fixes bors-ng#21, position alert boxes where they don't move stuff below them
and add a "close button" for them.
@notriddle notriddle mentioned this issue Sep 20, 2017
Merged
notriddle added a commit to notriddle/bors-ng that referenced this issue Sep 20, 2017
@notriddle
Change the alert box layout
2676a4f 
Fixes bors-ng#19, have the notification unhide an element instead of adding it.

Fixes bors-ng#21, position alert boxes where they don't move stuff below them
and add a "close button" for them.
bors bot added a commit that referenced this issue Sep 27, 2017
@bors
Merge #298
ff8f02e 
298: Improve the alert boxes on the dashboard page r=notriddle a=notriddle

![Adds a close button, removes duplicates, and changes the layout to a GMail-esque fixed position box at the top of the screen.](https://user-images.githubusercontent.com/1593513/30672252-34b18510-9e20-11e7-9918-324eaca2f75c.PNG)

* Fixes #19
* Fixes #21
@bors bors bot closed this as completed in #298 Sep 27, 2017
bors bot added a commit that referenced this issue Sep 19, 2018
@bors @dependabot-support
Merge #465
8a97477 
465: Bump clean-css-brunch from 2.0.0 to 2.10.0 r=notriddle a=dependabot[bot]

Bumps [clean-css-brunch](https://github.com/brunch/clean-css-brunch) from 2.0.0 to 2.10.0.
<details>
<summary>Commits</summary>

- [`3517524`](brunch/clean-css-brunch@3517524) Release 2.10.0.
- [`a012b48`](brunch/clean-css-brunch@a012b48) Refactor tests ([#21](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/21))
- [`c1728c8`](brunch/clean-css-brunch@c1728c8) Use eslint-config-brunch ([#19](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/19))
- [`0369e48`](brunch/clean-css-brunch@0369e48) Use latest Node.js in Travis ([#20](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/20))
- [`6e83584`](brunch/clean-css-brunch@6e83584) Rewrite examples in CoffeeScript to JS ([#18](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/18))
- [`6ef25cf`](brunch/clean-css-brunch@6ef25cf) Link to CleanCSS repo API options ([#17](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/17))
- [`69a58ec`](brunch/clean-css-brunch@69a58ec) Fix brunch/brunch#1486 ([#16](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/16))
- [`d33089b`](brunch/clean-css-brunch@d33089b) Merge pull request [#14](https://github-redirect.dependabot.com/brunch/clean-css-brunch/issues/14) from brunch/eslint2
- [`62f5220`](brunch/clean-css-brunch@62f5220) Update ESLint to 2.1.0
- [`3fc3d30`](brunch/clean-css-brunch@3fc3d30) Add travis.
- Additional commits viewable in [compare view](brunch/clean-css-brunch@2.0.0...2.10.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=clean-css-brunch&package-manager=npm_and_yarn&previous-version=2.0.0&new-version=2.10.0)](https://dependabot.com/compatibility-score.html?dependency-name=clean-css-brunch&package-manager=npm_and_yarn&previous-version=2.0.0&new-version=2.10.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the alert boxes on the dashboard page notriddle/bors-ng
1 participant
@notriddle