This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fix CODEOWNERS failure due to hardcoded "master" #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our repository does not use `master` as the mainline for bors. Bors would erroneously pass the codeowners check, and in the logs it would get a 404: ``` [error] GET https://api.github.com/repositories/123456/contents/.github/CODEOWNERS -> 404 (127.281 ms) ``` *I have not tested this PR*. I do not know Elixir, but this seems to be a good starting point for a change. And improvement could be to fail if `use_codeowners` is true and the http request fails. Hopefully this is a good jumping off point. My coworker knows Elixir and has contributed in the past, so maybe they can get this PR into a better state if it's not acceptable as-is :)
|
Seems like this change has raised some CI hackles ;) |
Basically, the old behavior was to use the code owners of the base branch, which I'm pretty sure is also what GitHub does.
|
Not hard to fix the problem, now that you've pointed it out. Thanks! |
|
Build succeeded: |
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Feb 1, 2021
Add @quicksnap to new contributors list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our repository does not use
masteras the mainline for bors. Bors is erroneously passing the codeowners check, and in the logs it would get a 404:I have not tested this PR. I do not know Elixir, but this seems to be a good starting point for a change. An improvement could be that if
use_codeownersis true and the http request fails, the codeowners check should fail.Hopefully this is a good jumping off point. My coworker knows Elixir and has contributed in the past, so maybe they can get this PR into a better state if it's not acceptable as-is :)