This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Enable custom dashboard header & footer #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to set DASHBOARD_HEADER_HTML to customize the navigation bar of the dashboard pages. Fixes bors-ng#377
Allows the user to set DASHBOARD_FOOTER_HTML to customize the informational message at the bottom of the dashboard pages. Fixes bors-ng#376
|
Looks like the failure is a line length issue on the default header markup. I can't see a good answer there, how would you suggest formatting it @notriddle? |
This allows long URLs and stuff to be in there.
|
I've just gone ahead and turned the style checker off in the config files. That might not be the greatest thing ever, but I'm more concerned about coding style in the code itself anyway. |
bors bot
added a commit
that referenced
this pull request
Mar 29, 2018
387: Enable custom dashboard header & footer r=notriddle a=couchand These changes allow a user to set `DASHBOARD_HEADER_HTML` and `DASHBOARD_FOOTER_HTML` to customize the dashboard. Fixes #376 #377 One question I had was about the proper indentation for the default values. As it is they're just verbatim moved from the template file, but I could see reformatting them. (My first Elixir change ever! Figured this would be a good way to get started contributing here, before diving into some of the more involved issues I've got my eye on.)
Build succeeded |
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Mar 29, 2018
Add @couchand as a first-time contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow a user to set
DASHBOARD_HEADER_HTMLandDASHBOARD_FOOTER_HTMLto customize the dashboard.Fixes #376 #377
One question I had was about the proper indentation for the default values. As it is they're just verbatim moved from the template file, but I could see reformatting them.
(My first Elixir change ever! Figured this would be a good way to get started contributing here, before diving into some of the more involved issues I've got my eye on.)