New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom dashboard header & footer #387

Merged
merged 3 commits into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@couchand
Contributor

couchand commented Mar 29, 2018

These changes allow a user to set DASHBOARD_HEADER_HTML and DASHBOARD_FOOTER_HTML to customize the dashboard.

Fixes #376 #377

One question I had was about the proper indentation for the default values. As it is they're just verbatim moved from the template file, but I could see reformatting them.

(My first Elixir change ever! Figured this would be a good way to get started contributing here, before diving into some of the more involved issues I've got my eye on.)

couchand added some commits Mar 29, 2018

Enable dashboard header customization
Allows the user to set DASHBOARD_HEADER_HTML to customize the
navigation bar of the dashboard pages.

Fixes #377
Enable dashboard footer customization
Allows the user to set DASHBOARD_FOOTER_HTML to customize the
informational message at the bottom of the dashboard pages.

Fixes #376
@couchand

This comment has been minimized.

Contributor

couchand commented Mar 29, 2018

Looks like the failure is a line length issue on the default header markup. I can't see a good answer there, how would you suggest formatting it @notriddle?

Disable dogma in configuration files
This allows long URLs and stuff to be in there.
@notriddle

This comment has been minimized.

Member

notriddle commented Mar 29, 2018

I've just gone ahead and turned the style checker off in the config files. That might not be the greatest thing ever, but I'm more concerned about coding style in the code itself anyway.

@notriddle

bors r+

bors bot added a commit that referenced this pull request Mar 29, 2018

Merge #387
387: Enable custom dashboard header & footer r=notriddle a=couchand

These changes allow a user to set `DASHBOARD_HEADER_HTML` and `DASHBOARD_FOOTER_HTML` to customize the dashboard.

Fixes #376 #377 

One question I had was about the proper indentation for the default values.  As it is they're just verbatim moved from the template file, but I could see reformatting them.

(My first Elixir change ever!  Figured this would be a good way to get started contributing here, before diving into some of the more involved issues I've got my eye on.)
@bors

This comment has been minimized.

Contributor

bors bot commented Mar 29, 2018

@bors bors bot merged commit b85d004 into bors-ng:master Mar 29, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Mar 29, 2018

Add bors-ng/bors-ng#387
Add @couchand as a first-time contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment