Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for the mapping of types to their json format #365

Closed
bergmark opened this issue Feb 9, 2016 · 2 comments · Fixed by #429
Closed

Add regression tests for the mapping of types to their json format #365

bergmark opened this issue Feb 9, 2016 · 2 comments · Fixed by #429

Comments

@bergmark
Copy link
Collaborator

bergmark commented Feb 9, 2016

We have a lot of roundtrip tests for the formats but they don't verify that the format doesn't accidentally change (as could be seen by the format for Either accidentally changing in v0.10).

Would someone be interested in adding a comprehensive set of tests for all instances? First priority is to check the format on successful encoding/decoding. An extension of this is to also verify that bad input isn't allowed, but that is more open-ended.

See https://github.com/bos/aeson/blob/master/tests/UnitTests.hs#L216

@bergmark
Copy link
Collaborator Author

I'm re-opening this since I'm working on making it more comprehensive.

@bergmark bergmark reopened this Aug 15, 2016
@bergmark bergmark removed their assignment Mar 19, 2017
@phadej
Copy link
Collaborator

phadej commented Mar 12, 2022

I think this in a good shape, if you think otherwise let's re-open with an explicit list of types, otherwise this is not actionable.

@phadej phadej closed this as completed Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants