Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nested list cases LogScaled #501

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Make nested list cases LogScaled #501

merged 2 commits into from
Jan 3, 2017

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Dec 23, 2016

Resolve #496. On my machine test run goes from 15sec to around 5sec.

@bergmark bergmark added this to the 1.0.3.0 milestone Dec 23, 2016
bergmark
bergmark requested changes Dec 23, 2016
View reviewed changes
Copy link
Collaborator

@bergmark bergmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke on older ghcs

@phadej
Copy link
Collaborator Author

phadej commented Dec 24, 2016

I see, it's probably because of arithmoi. I'll make a integer-logarithms package specially for this. Seehttps://github.com/Bodigrim/arithmoi/issues/45

@bergmark bergmark removed this from the 1.1.0.0 milestone Jan 1, 2017
@phadej
Copy link
Collaborator Author

phadej commented Jan 1, 2017

I'm not sure whether cache reset is needed on travis

@phadej
Copy link
Collaborator Author

phadej commented Jan 3, 2017

ping @bergmark, is there still something?

@bergmark bergmark merged commit d470ac6 into haskell:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmark bergmark bergmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phadej @bergmark