Remove the default value for the integer-simple flag. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a default seems to require users to explicitly override the flag if they want to enable it. Leaving it off allows Cabal to automatically figure out the proper value of the flag, which is handy, especially when text is at the bottom of a long dependency chain.
|
I wonder if @dcoutts or @TomMD could weigh in on this? @TomMD wrote the integer-simple support, and alas I do not understand whatever magic Cabal performs in this situation. So unless one of them can provide a positive opinion that this will not break people's existing setups, I am inclined to leave your pull request unmerged. |
|
I am fine with this change. Also note that my uses (most uses?) of integer-simple will disappear once library GMP bindings are no longer a problem as I understand will be the case with GHC 7.10. |
bos
added a commit
that referenced
this pull request
Dec 16, 2014
Remove the default value for the integer-simple flag.
bos
added a commit
that referenced
this pull request
Feb 18, 2015
Remove the default value for the integer-simple flag.
|
This change breaks the build of several packages that depend on text. integer-simple is not on hackage and so cabal build will fail. Cabal does not correctly infer the value for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a default seems to require users to explicitly override the flag if they
want to enable it. Leaving it off allows Cabal to automatically figure out the
proper value of the flag, which is handy, especially when text is at the bottom
of a long dependency chain.