Implement getAddress / factor out some code #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrejMitrovic
added
the
type-refactoring
AndrejMitrovic
force-pushed
the
various-improvements
branch
from
5c3a868
to
911fd0b
Compare
|
Love that last commit. As for the Vibe.d deserialization one, not too convinced it's the right solution. Could you take it out for the time being ? |
|
Actually yes I guess that one is more in line with belonging in #621, I'll remove it. |
AndrejMitrovic
force-pushed
the
various-improvements
branch
from
911fd0b
to
9a36fca
Compare
This function was only used from one place.
Geod24
force-pushed
the
various-improvements
branch
from
9a36fca
to
2385f4e
Compare
Codecov Report
@@ Coverage Diff @@
## v0.x.x #631 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 62 62
Lines 4564 4564
=======================================
Hits 4111 4111
Misses 453 453
Continue to review full report at Codecov.
|
The NetworkManager in the unittests uses the public key of the node as the effective address, but then the base class also used IP-based address banning despite of that. By abstracting the address, we can keep the behavior predictable. In addition, we will need to pass the address later when the handshake stage is changed later in preparation to fix bosagora#606
Geod24
force-pushed
the
various-improvements
branch
from
2385f4e
to
a43d2ad
Compare
Geod24
approved these changes
Mar 5, 2020
AndrejMitrovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #621