Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block timestamp to block header #253

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add block timestamp to block header #253

merged 1 commit into from
Jan 14, 2021

Conversation

TrustHenry
Copy link
Member

Upgrade SDK to 0.0.13
Tests changes and due to the addition of type timestamp in the block header.

@TrustHenry
Copy link
Member Author

It was closed due to @MichaelKim20's mistake, open it again.

@TrustHenry
Copy link
Member Author

Cause of Docker Build Error

node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp WARN Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v5.0.1/napi-v6-linux-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for sqlite3@5.0.1 and node@14.15.4 (node-v83 ABI, musl) (falling back to source compile with node-gyp)

@TrustHenry
Copy link
Member Author

TryGhost/node-sqlite3#1424

Try with sqlite3@5.0.0

@TrustHenry
Copy link
Member Author

https://github.com/bpfkorea/stoa/blob/9e40408e0c72b1b0b530209d786d88bb07a7e3e8/package-lock.json#L2359-L2367

@TrustHenry
Add block timestamp to block header
39cade5 
Upgrade SDK to 0.0.13
Tests changes and due to the addition of type timestamp in the block header.
@TrustHenry
Copy link
Member Author

It's Green.

MichaelKim20
MichaelKim20 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@MichaelKim20 MichaelKim20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@MichaelKim20 MichaelKim20 merged commit f997162 into bosagora:v0.x.x Jan 14, 2021
@TrustHenry TrustHenry deleted the stamp branch January 14, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKim20 MichaelKim20 MichaelKim20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrustHenry @MichaelKim20