Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for dask distributed example #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LGro
Copy link
Member

@LGro LGro commented Jun 5, 2023

  • Wrap the dask distributed example in a main
  • Add dask example to tests
  • Remove superfluous integration test marker

@LGro LGro requested a review from lreeb June 5, 2023 13:40
@github-actions

This comment was marked as outdated.

@LGro LGro force-pushed the feature/test-dask-example branch from 2179726 to 4dfa0c1 Compare June 5, 2023 14:07
@LGro

This comment was marked as resolved.

@LGro LGro force-pushed the feature/test-dask-example branch from 4dfa0c1 to f9ac0e3 Compare June 6, 2023 07:37
Copy link
Collaborator

@lreeb lreeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the tests fail? Is it a problem with running them on the github actions runner?

@LGro
Copy link
Member Author

LGro commented Jun 6, 2023

Why do the tests fail? Is it a problem with running them on the github actions runner?

That's unclear to me so far, I'm suspecting an issue with dask opening up ports on localhost and trying to connect locally via tcp/ip. If you have time, feel free to take a look as well.

Signed-off-by: Grossberger Lukas (CR/AIR2.2) <Lukas.Grossberger@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants