-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] IAVL store wrapper #916
Conversation
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
=========================================
- Coverage 60.47% 59.88% -0.6%
=========================================
Files 159 162 +3
Lines 11203 11452 +249
=========================================
+ Hits 6775 6858 +83
- Misses 3629 3792 +163
- Partials 799 802 +3
Continue to review full report at Codecov.
|
How about that we make a branch for it? and make a pr of this branch (for master rebasing) :-> |
@anarcher good idea. However, as you can see, this is in WIP. |
IMHO, |
I am not clear that we have account (only) based states? Block.StateRoot = MultiStore's Roothash and each of substores can be accounts(one of StoreKVKey) and contracts, storages... (staking or gov...) |
@anarcher /balance/(address, balance) pair for a data item Is it makes sense? This is a example code snippet
|
My first about storage is that storage treated as []byte from storage type. ( accAddress -> storage bytes ) It means that we storage items (k/v) saved one byte array in store (with amino) So we don’t need to prefix if it cares like this. But l am not sure about it. We need to have times to consider it :-) |
Github Issue
Background
Solution
Possible Drawbacks