Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column title (padding, icon-size, and checkBox size to auto-fit calculation #715

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Milad-Akarie
Copy link
Contributor

Hello @bosskmk
as the title suggests the current column auto-fit function does not consider column title, padding, icon-size ..etc and this PR should fix that

This's the before behaviour

before_auto_fit_fix

And this's the after behaviour
after_auto_fit_fix

NOTE
The columnAutoFit test fails now and honestly I have no idea how to test the new implementation as the old test was comparing the auto-fitted width to a fixed width ( min column width ).

@Milad-Akarie
Copy link
Contributor Author

@bosskmk Can you please take a look at this?

@bosskmk
Copy link
Owner

bosskmk commented Jan 10, 2023

@Milad-Akarie
Lately I haven't been paying attention to this project.
I will come back to this project soon.

@bosskmk
Copy link
Owner

bosskmk commented Feb 9, 2023

I checked the code.
Width adjustment according to the state of rowGroup should be added.
I will distribute this PR with this added.

@Milad-Akarie
Copy link
Contributor Author

@bosskmk I don't think this PR is merged?

@Milad-Akarie
Copy link
Contributor Author

@bosskmk any updates here?

@Milad-Akarie
Copy link
Contributor Author

Hey @bosskmk grouped rows are now considered in the calculation

Mar-14-2023 5-32-32 PM

@Milad-Akarie
Copy link
Contributor Author

Hey @bosskmk is there a problem with this PR?

@doonfrs
Copy link

doonfrs commented Dec 7, 2023

doonfrs added a commit to doonfrs/pluto_grid_plus that referenced this pull request Dec 7, 2023
bastaware pushed a commit to bastaware/pluto_grid that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants