cmd/bosun: skiplast cmdline switch for development (#1725)

cmd/bosun/conf/conf.go

@@ -63,6 +63,7 @@ type Conf struct {
 	Lookups          map[string]*Lookup
 	Squelch          Squelches `json:"-"`
 	Quiet            bool
+	SkipLast         bool
 	NoSleep          bool
 	ShortURLKey      string
 	InternetProxy    string

cmd/bosun/main.go

@@ -68,6 +68,7 @@ var (
 	flagQuiet    = flag.Bool("q", false, "quiet-mode: don't send any notifications except from the rule test page")
 	flagNoChecks = flag.Bool("n", false, "no-checks: don't run the checks at the run interval")
 	flagDev      = flag.Bool("dev", false, "enable dev mode: use local resources; no syslog")
+	flagSkipLast = flag.Bool("skiplast", false, "skip loading last datapoints from and to redis: useful for speeding up bosun startup time during development")
 	flagVersion  = flag.Bool("version", false, "Prints the version and exits")
 
 	mains []func()
@@ -100,6 +101,9 @@ func main() {
 	if err := metadata.Init(httpListen, false); err != nil {
 		slog.Fatal(err)
 	}
+	if *flagSkipLast {
+		c.SkipLast = true
+	}
 	if err := sched.Load(c); err != nil {
 		slog.Fatal(err)
 	}

cmd/bosun/sched/sched.go

@@ -87,7 +87,7 @@ func (s *Schedule) Init(c *conf.Conf) error {
 		}
 	}
 	if s.Search == nil {
-		s.Search = search.NewSearch(s.DataAccess)
+		s.Search = search.NewSearch(s.DataAccess, c.SkipLast)
 	}
 	if c.StateFile != "" {
 		s.db, err = bolt.Open(c.StateFile, 0600, nil)
@@ -511,6 +511,9 @@ func Close() {
 }
 
 func (s *Schedule) Close() {
+	if s.Conf.SkipLast {
+		return
+	}
 	err := s.Search.BackupLast()
 	if err != nil {
 		slog.Error(err)

cmd/bosun/search/search.go

@@ -36,16 +36,18 @@ func init() {
 	metadata.AddMetricMeta("bosun.search.dropped", metadata.Counter, metadata.Count, "Number of datapoints discarded without being saved to redis")
 }
 
-func NewSearch(data database.DataAccess) *Search {
+func NewSearch(data database.DataAccess, skipLast bool) *Search {
 	s := Search{
 		DataAccess: data,
 		last:       make(map[string]map[string]*database.LastInfo),
 		indexQueue: make(chan *opentsdb.DataPoint, 300000),
 	}
 	collect.Set("search.index_queue", opentsdb.TagSet{}, func() interface{} { return len(s.indexQueue) })
-	s.loadLast()
-	go s.redisIndex(s.indexQueue)
-	go s.backupLoop()
+	if !skipLast {
+		s.loadLast()
+		go s.redisIndex(s.indexQueue)
+		go s.backupLoop()
+	}
 	return &s
 }
 

cmd/bosun/search/search_test.go

@@ -14,7 +14,7 @@ var testSearch *Search
 
 func TestMain(m *testing.M) {
 	testData, closeF := dbtest.StartTestRedis(9990)
-	testSearch = NewSearch(testData)
+	testSearch = NewSearch(testData, false)
 	status := m.Run()
 	closeF()
 	os.Exit(status)