Revert "* This patch will fix unknown incident being ignored"

This reverts commit 21e6b64aa5d34070dc9fe632fd415b732990687f.

cmd/bosun/conf/conf.go

@@ -433,7 +433,6 @@ type Alert struct {
 	UnknownsNormal   bool
 	UnjoinedOK       bool `json:",omitempty"`
 	Log              bool
-	IgnoreError      bool
 	RunEvery         int
 	ReturnType       models.FuncType
 

cmd/bosun/conf/rule/loaders.go

@@ -225,8 +225,6 @@ func (c *Conf) loadAlert(s *parse.SectionNode) {
 			a.UnknownsNormal = true
 		case "log":
 			a.Log = true
-		case "ignoreError":
-			a.IgnoreError = true
 		case "runEvery":
 			var err error
 			a.RunEvery, err = strconv.Atoi(v)

cmd/bosun/sched/check.go

@@ -116,6 +116,7 @@ func (s *Schedule) runHistory(r *RunHistory, ak models.AlertKey, event *models.E
 	// get existing open incident if exists
 	var incident *models.IncidentState
 	rt := &models.RenderedTemplates{}
+
 	incident, err = data.GetOpenIncident(ak)
 	if err != nil {
 		return
@@ -567,12 +568,8 @@ func (s *Schedule) CheckAlert(T miniprofiler.Timer, r *RunHistory, a *conf.Alert
 	unevalCount, unknownCount := markDependenciesUnevaluated(r.Events, deps, a.Name)
 	if err != nil {
 		slog.Errorf("Error checking alert %s: %s", a.Name, err.Error())
-		if a.IgnoreUnknown {
-			removeUnknownEvents(r.Events, a.Name)
-		}
-		if !a.IgnoreError {
-			s.markAlertError(a.Name, err)
-		}
+		removeUnknownEvents(r.Events, a.Name)
+		s.markAlertError(a.Name, err)
 	} else {
 		s.markAlertSuccessful(a.Name)
 	}
@@ -616,13 +613,6 @@ func markDependenciesUnevaluated(events map[models.AlertKey]*models.Event, deps
 		if ak.Name() != alert {
 			continue
 		}
-
-		if len(deps) == 0 {
-			if ev.Status == models.StUnknown {
-				unknownCount++
-			}
-		}
-
 		for _, dep := range deps {
 			if len(dep.Group) == 0 || dep.Group.Overlaps(ak.Group()) {
 				ev.Unevaluated = true
@@ -681,11 +671,6 @@ func (s *Schedule) CheckExpr(T miniprofiler.Timer, rh *RunHistory, a *conf.Alert
 		return nil, nil, true
 	}
 	if err != nil {
-		// Create a alertkey with empty tag set, since the reslut was empty
-		ak := models.NewAlertKey(a.Name, opentsdb.TagSet{})
-		event := new(models.Event)
-		event.Status = models.StUnknown
-		rh.Events[ak] = event
 		return
 	}
 Loop: