This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Conf int with reload - #1817
Merged
Merged
Conf int with reload#1817
Conversation
Closed
Member
Author
kylebrandt
force-pushed
the
confIntWithReload
branch
from
July 13, 2016 16:21
fbb554b to
371e02c
Compare
Member
Author
|
example file save hook https://gist.github.com/kylebrandt/c4c9099118bea6e4ab793e6b657a1c2c |
Member
Author
|
Example sys conf |
| StateFile string | ||
| LedisDir string | ||
| LedisBindAddr string | ||
| type SystemConfProvider interface { |
Contributor
There was a problem hiding this comment.
I think the interface adds complexity here we don't really need. Why not just a struct without Getter Functions? Are we afraid some code will change it without going through the conf package? I'm not really super worried about that.
Member
Author
There was a problem hiding this comment.
I'm okay with removing the systemconf interface.
Contributor
|
That's all I have for now. |
…g-init By passing the settings in the template, we avoid http requests that are not needed
kylebrandt
force-pushed
the
confIntWithReload
branch
from
July 26, 2016 00:31
146e728 to
809e34e
Compare
| @@ -0,0 +1,52 @@ | |||
| Thoughts: | |||
Contributor
There was a problem hiding this comment.
Lets go ahead and delete this at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip: