Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Conf int with reload - #1817

Merged
kylebrandt merged 67 commits into
masterfrom
confIntWithReload
Jul 26, 2016
Merged

kylebrandt merged 67 commits into
masterfrom
confIntWithReload

Conversation

@kylebrandt

Copy link
Copy Markdown
Member

wip:

# kbrandt at grove in ~ on git:master x [16:19:15]
$ curl -XPOST 'http://localhost:8080/api/config/alert' -d "{
    \"Name\" : \"meowNew\", \"AlertText\" : \"alert meowNew {\n\twarn = 0 + 6\n}\", \"Hash\": \"\"
}"
reloaded%
# kbrandt at grove in ~ on git:master x [16:19:12]
$ curl -XDELETE 'http://localhost:8080/api/config/alert/meowNew'
meowNew deleted%

@kylebrandt kylebrandt mentioned this pull request Jul 9, 2016
@kylebrandt

Copy link
Copy Markdown
Member Author

#705

@kylebrandt

Copy link
Copy Markdown
Member Author

@kylebrandt

Copy link
Copy Markdown
Member Author

Example sys conf

Hostname = "bosun.example.com"
HTTPListen = ":8080"
TimeAndDate = [ 202, 75, 179, 136 ]
ShortURLKey = "aKey"
CommandHookPath = "/Users/kbrandt/src/hook/hook"
RuleFilePath = "/Users/kbrandt/src/testProdRepo/prod.conf"

[OpenTSDBConf]
    Host = "ny-tsdb01:4242"
    Version = 2.2
    ResponseLimit = 25000000

#Test comment

[ElasticConf]
    Hosts = ["http://ny-lselastic01.example.com:9200", "http://ny-lselastic02.example.com:9200","http://ny-lselastic03.example.com:9200"]

[DBConf]
    RedisHost = "localhost:6389"

[SMTPConf]
    EmailFrom = "bosun@example.com"
    Host = "mail.example.com"

Comment thread cmd/bosun/conf/conf.go
StateFile string
LedisDir string
LedisBindAddr string
type SystemConfProvider interface {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the interface adds complexity here we don't really need. Why not just a struct without Getter Functions? Are we afraid some code will change it without going through the conf package? I'm not really super worried about that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with removing the systemconf interface.

@captncraig

Copy link
Copy Markdown
Contributor

That's all I have for now.

Comment thread branch-notes.md Outdated
@@ -0,0 +1,52 @@
Thoughts:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go ahead and delete this at this point.

@kylebrandt
kylebrandt merged commit 554d588 into master Jul 26, 2016
@kylebrandt
kylebrandt deleted the confIntWithReload branch August 18, 2016 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants