New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conf int with reload #1817
Conf int with reload #1817
Conversation
fbb554b
to
371e02c
Compare
example file save hook https://gist.github.com/kylebrandt/c4c9099118bea6e4ab793e6b657a1c2c |
Example sys conf
|
StateFile string | ||
LedisDir string | ||
LedisBindAddr string | ||
type SystemConfProvider interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the interface adds complexity here we don't really need. Why not just a struct without Getter Functions? Are we afraid some code will change it without going through the conf package? I'm not really super worried about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with removing the systemconf interface.
That's all I have for now. |
…g-init By passing the settings in the template, we avoid http requests that are not needed
146e728
to
809e34e
Compare
@@ -0,0 +1,52 @@ | |||
Thoughts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go ahead and delete this at this point.
wip: