Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove free TLDs for more general info. #6

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@Andre601
Copy link
Contributor

commented Aug 10, 2019

Remove the examples of .tk and .ga to have more general info and also mention it should be a paid TLD.

This closes #5

It's a Draft PR for now to keep it open for discussion and changes. If all maintainers agree can this be turned into a full PR.

@Andre601 Andre601 referenced this pull request Aug 10, 2019
@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I wonder if this should also update point 2 so that it just discusses the use of glitch without specific reference to the subdomain as point 1 now covers that?

@Andre601

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

I still think that the usage of subdomains should be avoided. Sure there is discord.bots.gg that does this, but I personally think that it would only make stuff more complicated... Like what is the domain itself for?

Also, people would come with the argument that glitch is a respectable domain (and TLD) so...

@Andre601

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Also, should we perhaps include some info about the Discord of the bot list?
Like they should also follow some general practices there.

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I still think that the usage of subdomains should be avoided. Sure there is discord.bots.gg that does this, but I personally think that it would only make stuff more complicated... Like what is the domain itself for?

Neither of these cover the general use of subdomain, which is fine. I think they’re fine to use if appropriate such as discord.bots.gg - the ambiguity of not having a specific point about this works well.

Also, people would come with the argument that glitch is a respectable domain (and TLD) so...

Ah yeah, I hadn’t considered that. I wonder if custom covers this argument or if a user could say their glitch subdomain was custom?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Also, should we perhaps include some info about the Discord of the bot list?

This should be a separate issue for discussion. However, I don’t believe we should as it is not a requirement that a list has a Discord server - some don’t.

@Andre601

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Ah yeah, I hadn’t considered that. I wonder if custom covers this argument or if a user could say their glitch subdomain was custom?

You would be surprised how many people think that....

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

You would be surprised how many people think that....

True, leave it as is then :)

@Andre601 Andre601 referenced this pull request Aug 11, 2019
@Andre601

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

Is this PR good now, so that I can turn it into a full PR?

@MattIPv4

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@Andre601 Seems fine to me

@Andre601 Andre601 marked this pull request as ready for review Aug 13, 2019

@MattIPv4
Copy link
Member

left a comment

Lgtm.

@MattIPv4 MattIPv4 merged commit c1120a4 into botblock:master Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.