Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove free TLDs for more general info. #6

Merged
merged 1 commit into from Aug 13, 2019
Merged

Remove free TLDs for more general info. #6

merged 1 commit into from Aug 13, 2019

Conversation

Andre601
Copy link
Contributor

Remove the examples of .tk and .ga to have more general info and also mention it should be a paid TLD.

This closes #5

It's a Draft PR for now to keep it open for discussion and changes. If all maintainers agree can this be turned into a full PR.

@Andre601 Andre601 mentioned this pull request Aug 10, 2019
Closed
@MattIPv4
Copy link
Member

I wonder if this should also update point 2 so that it just discusses the use of glitch without specific reference to the subdomain as point 1 now covers that?

@Andre601
Copy link
Contributor Author

I still think that the usage of subdomains should be avoided. Sure there is discord.bots.gg that does this, but I personally think that it would only make stuff more complicated... Like what is the domain itself for?

Also, people would come with the argument that glitch is a respectable domain (and TLD) so...

@Andre601
Copy link
Contributor Author

Also, should we perhaps include some info about the Discord of the bot list?
Like they should also follow some general practices there.

@MattIPv4
Copy link
Member

I still think that the usage of subdomains should be avoided. Sure there is discord.bots.gg that does this, but I personally think that it would only make stuff more complicated... Like what is the domain itself for?

Neither of these cover the general use of subdomain, which is fine. I think they’re fine to use if appropriate such as discord.bots.gg - the ambiguity of not having a specific point about this works well.

Also, people would come with the argument that glitch is a respectable domain (and TLD) so...

Ah yeah, I hadn’t considered that. I wonder if custom covers this argument or if a user could say their glitch subdomain was custom?

@MattIPv4
Copy link
Member

Also, should we perhaps include some info about the Discord of the bot list?

This should be a separate issue for discussion. However, I don’t believe we should as it is not a requirement that a list has a Discord server - some don’t.

@Andre601
Copy link
Contributor Author

Ah yeah, I hadn’t considered that. I wonder if custom covers this argument or if a user could say their glitch subdomain was custom?

You would be surprised how many people think that....

@MattIPv4
Copy link
Member

You would be surprised how many people think that....

True, leave it as is then :)

@Andre601 Andre601 mentioned this pull request Aug 11, 2019
Closed
@Andre601
Copy link
Contributor Author

Is this PR good now, so that I can turn it into a full PR?

@MattIPv4
Copy link
Member

@Andre601 Seems fine to me

@Andre601 Andre601 marked this pull request as ready for review August 13, 2019 16:19
MattIPv4
MattIPv4 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@MattIPv4 MattIPv4 merged commit c1120a4 into botblock:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify point 1 (TLD)
2 participants
@Andre601 @MattIPv4