This repository has been archived by the owner on Apr 28, 2021. It is now read-only.
feat: set slots in forms #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheel
suggested changes
Nov 5, 2020
| @@ -487,7 +497,9 @@ async def validate_prefilled( | |||
| prefilled_slots = {} | |||
| events = [] | |||
|
|
|||
| for slot_name in self.required_slots(tracker): | |||
| requiredSlots = self._requested_slot_without_slot_set(tracker) | |||
| @@ -23,7 +26,11 @@ def get_required_slots(self, tracker, start=None): | |||
| for edge in sorted(current_edges, key=lambda e: e.get("condition") is None): | |||
| target, condition = edge.get("target"), edge.get("condition") | |||
| if self.check_condition(tracker, condition): | |||
| required_slots.append(self.nodes.get(target)) | |||
| targetNode = self.nodes.get(target) | |||
| @@ -118,6 +118,32 @@ def required_slots_graph(conjunction="OR", negated=False): | |||
| ], | |||
| } | |||
|
|
|||
| def required_slots_graph_with_set_slots(conjunction="OR", negated=False): | |||
There was a problem hiding this comment.
don't copy the test -- just change required_slots_graph and test_required_slots
There was a problem hiding this comment.
Actually I don't want that because I specifically want to test if everything goes well when a graph does not end with a slot set.
There was a problem hiding this comment.
Then you can add slotset as a parameter of the existing test. I just don't like having two copies of the same 50+ lines.
pheel
approved these changes
Nov 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.