Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: socket io #346

Merged
merged 1 commit into from
Apr 15, 2021
Merged

fix: socket io #346

merged 1 commit into from
Apr 15, 2021

Conversation

MatthieuJnon
Copy link
Contributor

No description provided.

@lako90
Copy link

lako90 commented Mar 19, 2021

This solution is working for me, thanks

@nenads
Copy link

nenads commented Mar 24, 2021

What is status of this ?

@WeberJulian
Copy link

@dliuproduction would it be possible for you to approve this PR please ? This is a breaking bug.

@ptrkdy
Copy link

ptrkdy commented Apr 14, 2021

Hi, I think this would solve the following open discussion:

botfront/botfront#979

Also I think a version of the compiled JS needs to be added to CDN.

e.g.: https://cdn.jsdelivr.net/npm/rasa-webchat@1.0.0/
e.g.: https://storage.googleapis.com/cdn.botfront.cloud/botfront-widget-latest.js

Thanks!

Copy link

@cbissler cbissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is working for me too.
Would it be possible to merge this PR (and update the compiled build on CDN) ?
Currently, the 1.0.0 version of rasa-webchat can't work with de latest version of RASA and it's pretty annoying

@Gr8ayu
Copy link

Gr8ayu commented Apr 14, 2021

Please add CDN of javascript for </script>

@MatthieuJnon MatthieuJnon merged commit 4c1562d into master Apr 15, 2021
@WeberJulian
Copy link

Thank you @MatthieuJnon and @kenrilea :)

@Gr8ayu Gr8ayu mentioned this pull request Apr 15, 2021
Copy link

@coopeCoop coopeCoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sockets fixed w/ proper version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants