Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LaravelCache.php #1028

Merged
merged 2 commits into from
May 18, 2020
Merged

Update LaravelCache.php #1028

merged 2 commits into from
May 18, 2020

Conversation

hendrikheil
Copy link
Contributor

A recent change in Laravel 5.8 changed the TTL from minutes to seconds.
See https://laravel.com/docs/5.8/upgrade#cache-ttl-in-seconds for more details.

This would keep it compatible with other caching drivers also using minutes.

A recent change in Laravel 5.8 changed the TTL from minutes to seconds.
See https://laravel.com/docs/5.8/upgrade#cache-ttl-in-seconds for more details.
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #1028 into 2.0 will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.0    #1028      +/-   ##
============================================
- Coverage     82.95%   82.91%   -0.05%     
- Complexity      595      596       +1     
============================================
  Files            48       48              
  Lines          1561     1563       +2     
============================================
+ Hits           1295     1296       +1     
- Misses          266      267       +1
Impacted Files Coverage Δ Complexity Δ
src/Cache/LaravelCache.php 63.63% <100%> (+8.08%) 5 <0> (+1) ⬆️
src/Cache/RedisCache.php 83.33% <0%> (-2.39%) 16% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a2ed1...4351c43. Read the comment docs.

@xar
Copy link

xar commented Oct 6, 2019

@mpociot any chance to have this merged? Please

@feralheart
Copy link
Contributor

Hi,
Thank you for your PR

@feralheart feralheart merged commit 4156a61 into botman:2.0 May 18, 2020
@hendrikheil
Copy link
Contributor Author

My pleasure. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants