Add PSR-11 ContainerInterface (#713) #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
============================================
+ Coverage 83.44% 83.49% +0.04%
- Complexity 552 554 +2
============================================
Files 46 46
Lines 1450 1454 +4
============================================
+ Hits 1210 1214 +4
Misses 240 240
Continue to review full report at Codecov.
|
|
Thank you - the setter is just fine. |
DigicreateJens
pushed a commit
to DigicreateJens/botman
that referenced
this pull request
Apr 29, 2019
* Add PSR-11 ContainerInterface (botman#713) * fix cs
sasha-x
pushed a commit
to botman-fork/botman
that referenced
this pull request
Dec 26, 2019
* Add PSR-11 ContainerInterface (botman#713) * fix cs
sh41
added a commit
to sh41/botman
that referenced
this pull request
Mar 17, 2020
This adds new method to the HandlesConversations trait to allow Conversations to take advantage of the PSR11 interface added in botman#714. Allows conversations to be initiated like this: ```php $botman->setContainer($psr11Container); $botman->hears('Hello', function($bot) { $bot->startConversationService(OnboardingConversation::class); }); ``` I did think to modify the HandlesConversations::startConversation function but would have needed to change the signature to allow a string to be passed as the first argument which might cause BC issues. I've added tests for all existing tests that called the HandlesConversations::startConversation function and modified them to use HandlesConversations::startConversationService. The most interesting tests are `it_can_start_conversations_from_container_services` and `it_can_start_conversations_from_container_services_and_those_conversations_can_call_dependencies` as these show the functionality that I was trying to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #713
@mpociot
Do I have to add
ContainerInterface $container = nullto BotManFactory::create method?botman/src/BotManFactory.php
Lines 51 to 57 in 021f1e5