Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mountPath option to prepend a custom path #23

Closed
wants to merge 10 commits into from
Closed

add mountPath option to prepend a custom path #23

wants to merge 10 commits into from

Conversation

younes200
Copy link

sorry for the last PR.

Younes added 3 commits April 19, 2017 16:18
@coveralls
Copy link

coveralls commented Apr 19, 2017

Coverage Status

Coverage decreased (-17.07%) to 82.933% when pulling 3ce7e7f on InteractiveObject:master into 38f54a7 on botmasterai:master.

@jdwuarin
Copy link
Member

Hi Younes,

Thanks for your interest in Botmaster.
I get what you trying to do here. I guess the best way to do that would be to add a default setting called mountpath to settings and set it to '/' by default. Then in addBot and removeBot, replace the slash with ${settings.mountpath} (this avoids having to have an "if" block in both those functions). You would then ideally update and add a couple of tests in https://github.com/botmasterai/botmaster/blob/master/tests/botmaster/add_bot.js and https://github.com/botmasterai/botmaster/blob/master/tests/botmaster/constructor.js to reflect that.
And potentially also update the two last tests in https://github.com/botmasterai/botmaster/blob/master/tests/botmaster/remove_bot.js

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.0%) to 62.032% when pulling 28e73d6 on InteractiveObject:master into 38f54a7 on botmasterai:master.

1 similar comment
@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage decreased (-38.0%) to 62.032% when pulling 28e73d6 on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-38.7%) to 61.29% when pulling 555bead on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-38.8%) to 61.186% when pulling 3e5d50b on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-17.5%) to 82.48% when pulling 87f6eef on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-17.5%) to 82.48% when pulling ad5b7c4 on InteractiveObject:master into 38f54a7 on botmasterai:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-17.5%) to 82.48% when pulling ad5b7c4 on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-17.5%) to 82.48% when pulling ad5b7c4 on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-17.3%) to 82.749% when pulling 871c35f on InteractiveObject:master into 38f54a7 on botmasterai:master.

@coveralls
Copy link

coveralls commented May 26, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 54017f8 on InteractiveObject:master into 38f54a7 on botmasterai:master.

jdwuarin added a commit that referenced this pull request May 27, 2017
@jdwuarin
Copy link
Member

Support for something along those lines added in 3.1.0

@jdwuarin jdwuarin closed this May 27, 2017
@younes200
Copy link
Author

Thanks @jdwuarin and sorry for the delay ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants