This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix asadmin migration to check instance count, use autoscale terminate instead of ec2 terminate #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of ec2 terminate
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the asadmin migration process which can cause to shut down two instances at once. There is a short period of time when the old instance is destroyed but the autoscaling group did not create a new one yet. This fix checks the instance count too.
Also instead of terminating the ec2 instance we should use autoscale.terminate which is safer and also leaves a more friendly message in the asg history: "instance i-xxx was taken out of service in response to a user request."