S3 multipart upload: attributes swapped?

[tgal]

Hello! I'm not sure whether it's me who's making a mistake here or not (boto3 0.0.7):

>>> import boto3
>>> s3 = boto3.resource('s3')
>>> bucket = s3.Bucket('ubitricity-backup')
>>> o = bucket.Object('test')
>>> mpu = o.initiate_multipart_upload()
>>> mpu
s3.MultipartUpload(bucket_name='ubitricity-backup', object_key='test', id='WYDgB2hJrtoTHxWLVL.yz98bTrL.UCuQAk.iIpNeIm6pIl.CZoZ2Uk7mJmKDokQejymCurdjKBj4IQpJF2VAJmEjvjHfepJyWSGU1P7QVdiaDIvJSX_OK5w0omLPVOcu')
>>> part = mpu.MultipartUploadPart(1)
>>> part
s3.MultipartUploadPart(bucket_name='ubitricity-backup', object_key='WYDgB2hJrtoTHxWLVL.yz98bTrL.UCuQAk.iIpNeIm6pIl.CZoZ2Uk7mJmKDokQejymCurdjKBj4IQpJF2VAJmEjvjHfepJyWSGU1P7QVdiaDIvJSX_OK5w0omLPVOcu', multipart_upload_id='test', part_number=1)
>>> part.upload(Body = 'test')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/boto3/resources/factory.py", line 379, in do_action
    response = action(self, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/boto3/resources/action.py", line 77, in __call__
    response = getattr(parent.meta.client, operation_name)(**params)
  File "/usr/local/lib/python2.7/dist-packages/botocore/client.py", line 299, in _api_call
    raise ClientError(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (NoSuchUpload) when calling the UploadPart operation: The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.

In the MultipartUploadPart object the values for object_key and multipart_upload_id seem inverted.

Do I use this function in a wrong way?

[danielgtaylor]

This looks like an issue with the order of items here:

...
"Part": {
  "resource": {
    "type": "MultipartUploadPart",
    "identifiers": [
      { "target": "BucketName", "source": "identifier", "name": "BucketName" },
      { "target": "MultipartUploadId", "source": "identifier", "name": "Id" },       <--- whoops
      { "target": "ObjectKey", "source": "identifier", "name": "ObjectKey" },        <---
      { "target": "PartNumber", "source": "input" }
    ]
  }
}
...

https://github.com/boto/boto3/blob/develop/boto3/data/resources/s3-2006-03-01.resources.json#L701-L702

[danielgtaylor]

@tgal I have opened up a pull request against our new model validator so hopefully we can catch these sort of issues earlier next time:

amazon-archives/aws-model-validators#2

[danielgtaylor]

This is now released in 0.0.8.