Support plural references #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the way that references are created to reuse the existing response handling code for loading references. As a side effect, this supports plural references.
danielgtaylor
added
the
enhancement
Adds more tests and fixes a couple of longstanding issues so that plural references will actually work when used. Rather than just laying the groundwork like previous commits, this completes the feature.
|
@kyleknap the latest push includes the JMESPath data member fixes we discussed yesterday and updated tests. Please have another look! |
|
Looks good. 🚢 |
danielgtaylor
added a commit
that referenced
this pull request
Feb 5, 2015
Support plural references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the way that references are created to reuse the
existing response handling code for loading resources. As a side effect,
this supports plural references.
This is mainly future-proofing and removing some code duplication.
cc @jamesls @kyleknap