Calculate MD5 checksum for empty body #2181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangrewe
changed the title
jangrewe
changed the title
|
Hi @jangrewe, we just wanted to say thanks for bringing attention to this again. The issue you're seeing was an edge case we weren't accounting for in existing tests we had around empty files. We've made some tweaks to the original #1985, which should be merged shortly in #2221. I'm going to resolve this in favor of the new PR, but wanted to let you know we appreciate your part in getting this resolved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated fix for #1979 - very simple and using the pretty much same test as #1985