Adding smart default support #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2591 +/- ##
===========================================
+ Coverage 95.41% 95.42% +0.01%
===========================================
Files 59 59
Lines 11631 11832 +201
===========================================
+ Hits 11098 11291 +193
- Misses 533 541 +8
Continue to review full report at Codecov.
|
joguSD
approved these changes
Jan 15, 2022
joguSD
reviewed
Jan 15, 2022
botocore/session.py
Outdated
| default_config_resolver = self._get_internal_component( | ||
| 'default_config_resolver') | ||
| default_modes = default_config_resolver.get_default_modes() | ||
| default_modes.extend(['legacy', 'auto']) |
There was a problem hiding this comment.
It might make more sense to just have these be the base in the get_default_modes method and then extend it by the keys we find in the model file.
nateprewitt
approved these changes
Jan 15, 2022
zdutta
force-pushed
the
smart-defaults
branch
from
18464cd
to
7e3b3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
defaults_modeclient configuration option. Thedefaults_modewill be used to determine how certain default configuration options are resolved in the SDK. Configurations values impacted include:retry_mode,sts_regional_endpoints, s3us_east_1_regional_endpointandconnect_timeout.