Remove urllib3 __version__ info #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
approved these changes
May 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #2669 +/- ##
========================================
Coverage 95.31% 95.31%
========================================
Files 60 60
Lines 12208 12208
========================================
Hits 11636 11636
Misses 572 572 Continue to review full report at Codecov.
|
aws-sdk-python-automation
added a commit
that referenced
this pull request
May 4, 2022
* release-1.25.7: Bumping version to 1.25.7 Update to latest endpoints Update to latest models Remove urllib3 __version__ info to avoid confusing security scans (#2669)
memuller
added a commit
to memuller/botocore
that referenced
this pull request
May 10, 2022
* upstream_latest: (706 commits) Bumping version to 1.25.10 Update to latest endpoints Update to latest models Bumping version to 1.25.9 Update to latest endpoints Update to latest models Bumping version to 1.25.8 Update to latest endpoints Update to latest models Bumping version to 1.25.7 Update to latest endpoints Update to latest models Remove urllib3 __version__ info to avoid confusing security scans (boto#2669) Bumping version to 1.25.6 Update to latest endpoints Update to latest models Bumping version to 1.25.5 Update to latest endpoints Update to latest models Bumping version to 1.25.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendored copy of urllib3 was removed a few years ago, but exceptions were retained for backwards compatibility. The
__version__string for urllib3 was left for reference on which version they originated from. Certain security scanning tools appear to be doing naive checks to find this version number and assume vulnerabilities exist, despite us no longer including the code. We'll truncate__version__to an empty string to avoid the noise.