Unrevert s3 config #673
Merged
Unrevert s3 config #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
added
the
pr/needs-review
| Valid keys are: | ||
| * 'addressing_style' -- Refers to the style in which to address | ||
| s3 endpoints. Values must be a string that equals: | ||
| * auto -- Addressing style is chosen for user. Depending |
There was a problem hiding this comment.
It would be worth mentioning this is the default value.
|
Just had some small feedback. |
jamesls
added
incorporating-feedback
and removed
pr/needs-review
kyleknap
force-pushed
the
unrevert-s3-config
branch
from
99f271a
to
4c04307
Compare
|
@jamesls I updated based on feedback |
kyleknap
added
pr/needs-review
|
@kyleknap Can we get a test added for kyleknap@4c04307? |
|
@jamesls We already have one: https://github.com/boto/botocore/blob/develop/tests/unit/test_s3_addressing.py#L87. Or did you want a test for if it us-gov-west-1 is used but a path style of virtual is specified? |
|
I didn't see a case for the scenario we've been discussing:
Is there a test for this? |
|
Oh no I can add one for that then. |
|
@jamesls Test case added. |
|
|
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts back in place the s3 configuration options that I reverted because CLI integration tests were failing. Fixed the tests by putting back the
fix_s3_hostregistering to the default section so when the event for unregistering is called in the CLI with--endpoint-url, the registered handler does exist so it does get unregistered. This seemed like the safest way to ensure there was no breaking behavior in the CLI.Looked into trying to modify the session in the CLI, but that would have required making the session more mutable and adding more functionality to the session, which is not necessarily desired.
cc @Jamels @mtdowling @rayluo @JordonPhillips