Merge pull request #3063 from botpress/jhb-slack-unmount

fix(slack): disconnect websocket onBotUnmount
botpress · Mar 10, 2020 · 0ea93f1 · 0ea93f1
2 parents 1a34bff + 221ca89
commit 0ea93f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/modules/channel-slack/src/backend/client.ts b/modules/channel-slack/src/backend/client.ts
@@ -44,6 +44,12 @@ export class SlackClient {
     await this._setupRealtime()
   }
 
+  async shutdown() {
+    if (this.rtm) {
+      await this.rtm.disconnect()
+    }
+  }
+
   private async _setupInteractiveListener() {
     this.interactive.action({ type: 'button' }, async payload => {
       debugIncoming(`Received interactive message %o`, payload)

diff --git a/modules/channel-slack/src/backend/index.ts b/modules/channel-slack/src/backend/index.ts
@@ -37,6 +37,7 @@ const onBotUnmount = async (bp: typeof sdk, botId: string) => {
     return
   }
 
+  await client.shutdown()
   delete clients[botId]
 }
 

diff --git a/modules/channel-slack/src/backend/typings.ts b/modules/channel-slack/src/backend/typings.ts
@@ -1 +1,3 @@
-export type Clients = { [key: string]: any }
+import { SlackClient } from './client'
+
+export type Clients = { [key: string]: SlackClient }