Skip to content

Commit

Permalink
Revert "fix(core): disallow transitions to same node (resolve #900) (#…
Browse files Browse the repository at this point in the history
…962)"

This reverts commit cdfcd26.
  • Loading branch information
rndlaine committed Oct 31, 2018
1 parent dcab535 commit 183f2c9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
Expand Up @@ -171,9 +171,8 @@ export default class ConditionModalForm extends Component {
}

getNodeOptions() {
const { currentFlow: flow, currentNodeName } = this.props
const nodes = (flow && flow.nodes) || []
return nodes.filter(({ name }) => name !== currentNodeName).map(({ name }) => ({ label: name, value: name }))
const flow = this.props.currentFlow
return (flow && flow.nodes.map(({ name }) => ({ label: name, value: name }))) || []
}

renderNodesChoice() {
Expand Down
Expand Up @@ -92,8 +92,6 @@ export default class StandardNodePropertiesPanel extends Component {
readOnly={readOnly}
items={node.next}
header="Transitions"
currentFlow={this.props.flow}
currentNodeName={node.name}
subflows={this.props.subflows}
onItemsUpdated={items => this.props.updateNode({ next: items })}
copyItem={item => this.props.copyFlowNodeElement({ transition: item })}
Expand Down
Expand Up @@ -112,7 +112,6 @@ export default class TransitionSection extends Component {
{!readOnly && (
<ConditionModalForm
currentFlow={this.props.currentFlow}
currentNodeName={this.props.currentNodeName}
subflows={this.props.subflows}
show={this.state.showConditionalModalForm}
onClose={() => this.setState({ showConditionalModalForm: false, itemToEditIndex: null })}
Expand Down

1 comment on commit 183f2c9

@dmk23
Copy link

@dmk23 dmk23 commented on 183f2c9 Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this commit broke ALL node transitions, not just to self...

Fix here 352df05

Please sign in to comment.