chore(qna): sync NLU less often and in background

botpress · Jul 26, 2018 · 19360cd · 19360cd
1 parent ce88c93
commit 19360cd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/packages/functionals/botpress-qna/src/index.js b/packages/functionals/botpress-qna/src/index.js
@@ -54,7 +54,9 @@ module.exports = {
        */
       import(questions, { format = 'json' } = {}) {
         const questionsToSave = typeof questions === 'string' ? parsers[`${format}Parse`](questions) : questions
-        return Promise.each(questionsToSave, question => storage.saveQuestion({ ...question, enabled: true }))
+        return Promise.each(questionsToSave, question =>
+          storage.saveQuestion({ ...question, enabled: true }, null, false)
+        )
       },
 
       /**
@@ -162,11 +164,12 @@ module.exports = {
     router.post('/csv', upload.single('csv'), async (req, res) => {
       if (yn(req.body.isReplace)) {
         const questions = await storage.getQuestions()
-        await Promise.each(questions, ({ id }) => storage.deleteQuestion(id))
+        await Promise.each(questions, ({ id }) => storage.deleteQuestion(id, false))
       }
 
       try {
         await bp.qna.import(req.file.buffer.toString(), { format: 'csv' })
+        bp.nlu.provider.sync()
         res.end()
       } catch (e) {
         logger.error('QnA Error:', e)

diff --git a/packages/functionals/botpress-qna/src/storage.js b/packages/functionals/botpress-qna/src/storage.js
@@ -47,7 +47,7 @@ export default class Storage {
     }
   }
 
-  async saveQuestion(data, id = null) {
+  async saveQuestion(data, id = null, syncNlu = true) {
     id = id || getQuestionId(data)
     if (data.enabled) {
       await this.bp.nlu.storage.saveIntent(getIntentId(id), {
@@ -57,7 +57,9 @@ export default class Storage {
     } else {
       await this.bp.nlu.storage.deleteIntent(getIntentId(id))
     }
-    await this.syncNlu()
+    if (syncNlu) {
+      this.syncNlu()
+    }
     await this.ghost.upsertFile(this.qnaDir, `${id}.json`, JSON.stringify({ id, data }, null, 2))
     return id
   }
@@ -79,11 +81,13 @@ export default class Storage {
     return Promise.map(questions, question => this.getQuestion({ filename: question }))
   }
 
-  async deleteQuestion(id) {
+  async deleteQuestion(id, syncNlu = true) {
     const data = await this.getQuestion(id)
     if (data.data.enabled) {
       await this.bp.nlu.storage.deleteIntent(getIntentId(id))
-      await this.syncNlu()
+      if (syncNlu) {
+        this.syncNlu()
+      }
     }
     await this.ghost.deleteFile(this.qnaDir, `${id}.json`)
   }