Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mlb svm refac #2141

Closed
wants to merge 21 commits into from
Closed

Mlb svm refac #2141

wants to merge 21 commits into from

Conversation

maximelaboisson
Copy link
Contributor

@maximelaboisson maximelaboisson commented Jul 18, 2019 •
edited

The svm_classifier has now only two export functions; train & predict. These are self contained without external state, this will make it easier to create/train/predict context at run time. Meaning it is now the job of the engine to provider the proper models to the predict function as the classifier no longer has an internal state.

slvnperron
slvnperron reviewed Jul 22, 2019
View reviewed changes
modules/nlu/src/backend/engine.ts Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/context_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/context_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/predictions_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/predictions_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/predictions_utils.ts Outdated Show resolved Hide resolved
src/bp/ml/svm-js/core/svm.js Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/svm_classifier.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/svm_classifier.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/tfidf.ts Outdated Show resolved Hide resolved
EFF
EFF reviewed Aug 1, 2019
View reviewed changes
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still room for improvement but I think that will help for future development

jest.config.js Outdated Show resolved Hide resolved
modules/nlu/src/backend/engine.ts Show resolved Hide resolved
modules/nlu/src/backend/engine.ts Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/context_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/language/ft_featurizer.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/context_utils.ts Outdated Show resolved Hide resolved
modules/nlu/src/backend/pipelines/intents/context_utils.ts Outdated Show resolved Hide resolved
@EFF
Copy link
Member

EFF commented Aug 26, 2019

closing this as most of these changes are being integrated in a much bigger NLU refactor

@EFF EFF closed this Aug 26, 2019
@allardy allardy deleted the mlb_svm_refac branch September 12, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EFF EFF EFF left review comments

@slvnperron slvnperron slvnperron left review comments

@franklevasseur franklevasseur franklevasseur left review comments

@allardy allardy Awaiting requested review from allardy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maximelaboisson @EFF @slvnperron @franklevasseur