Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang-server): add option to run offline #2199

Merged
merged 8 commits into from Jul 31, 2019
Merged

feat(lang-server): add option to run offline #2199

merged 8 commits into from Jul 31, 2019

Conversation

rndlaine
Copy link
Contributor

@rndlaine rndlaine commented Jul 31, 2019 •
edited

  • The metadata file is not required in offline mode anymore
  • Flags are now in the assets

image

image

@rndlaine rndlaine changed the base branch from master to minor/12-1-0 July 31, 2019 18:38
@rndlaine rndlaine requested a review from a team July 31, 2019 19:07
slvnperron
slvnperron approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@slvnperron slvnperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rndlaine rndlaine merged commit 8a941a3 into minor/12-1-0 Jul 31, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slvnperron slvnperron slvnperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rndlaine @slvnperron