Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qna): fix redirection and incorrect message #2891

Merged
merged 1 commit into from Jan 28, 2020
Merged

fix(qna): fix redirection and incorrect message #2891

merged 1 commit into from Jan 28, 2020

Conversation

asashour
Copy link
Contributor

The points covered:

  1. A flow or node can currently be invalidated after the Q&A item creation, if they are deleted in Flow dialog, this would make the Q&A item has "incorrect redirection". This PR shows them with an error in the item list, and doesn't allow saving unless they are both fine.
  2. "Missing translations" in Editor/index.tsx was changed when the answers are empty only when isText, in other words, test case:
    a. Create an item with a single question, no answer, but a redirection
    b. Save it
    c. Open it, you will get an error, "missing translations"
  3. Logic in item list was changed to follow the one in point 2
  4. Flow name in item list is now user-friendly
  5. The save button was renamed to Add/Save instead of Save/Edit
  6. Full test of "missing translations" wasn't done because of lack of PRO license
  7. Lite view wasn't tested, because I don't know how, so the "flows" was marked optional

Copy link
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good ! Thank you ! The lite editor is only used by a new branch in active development, so we'll test it when we get there

@allardy allardy merged commit 38518be into botpress:master Jan 28, 2020
@asashour asashour deleted the qna-missing-translations branch January 28, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants