feat(channel-web): delete conversation #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annel-delete-conversation
…elete-conversation
…tpress into llp_web-channel-delete-conversation
allardy
reviewed
Dec 10, 2020
…tpress into llp_web-channel-delete-conversation
…tpress into llp_web-channel-delete-conversation
allardy
reviewed
Dec 14, 2020
|
@allardy @EFF The scope of this PR changed a little bit.
|
EFF
reviewed
Dec 16, 2020
* Draft * Added ConfirmDialog component into ui-shared-lite * Added transalations * Added conversation deletion from channel-web * Linting * Linting * Removed confirmDialog from ui-shared * Changed button behaviour to only delete conversation * Try importing blueprint css in channel-web * Typo * Duplicated confirmDialog. Lite version requires decline btn and labels * Fix
laurentlp
changed the base branch from
llp_hitl-delete-conversation
to
master
laurentlp
changed the title
EFF
approved these changes
Dec 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of clearing the conversation of the channel-web module.
Related to this PR #4288
In order to clear the conversation, the current conversation messages are deleted from the database and cleared from the UI. If something is unclear feel free to comment on it!
If you want to test the changes follow the steps detailed in this PR #4288.